Skip to content

Validate expression syntax and indexed access - #91

Merged
Dan Marshall (danmarshall) merged 8 commits into
mainfrom
fix/expression-validation
Oct 25, 2026
Merged

Dan Marshall (danmarshall) merged 8 commits into
mainfrom
fix/expression-validation

Conversation

@danmarshall

@danmarshall Dan Marshall (danmarshall) commented Oct 24, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

  • Fix the reported expression-injection escape by validating expression syntax and restricting computed access to numeric indices.
  • Preserve supported helpers, dataset lookups, and existing client URL-loading behavior.
  • Add focused regression tests for the original payload, related constructor escapes, and supported expressions.

Validation

  • All 5 expression regression tests pass locally.
  • Full client TypeScript compilation succeeds.
  • Browser/WebGPU rendering has not been smoke-tested.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 089dd5de-5a83-4bf9-a0d4-3afbd572168e
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 089dd5de-5a83-4bf9-a0d4-3afbd572168e
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 089dd5de-5a83-4bf9-a0d4-3afbd572168e
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 089dd5de-5a83-4bf9-a0d4-3afbd572168e
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 089dd5de-5a83-4bf9-a0d4-3afbd572168e
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 089dd5de-5a83-4bf9-a0d4-3afbd572168e
@danmarshall Dan Marshall (danmarshall) changed the title Validate expressions and initial sample selection Validate expression syntax and indexed access Oct 25, 2026
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 089dd5de-5a83-4bf9-a0d4-3afbd572168e
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 089dd5de-5a83-4bf9-a0d4-3afbd572168e
@danmarshall
Dan Marshall (danmarshall) merged commit db013fa into main Oct 25, 2026
5 checks passed
@danmarshall
Dan Marshall (danmarshall) deleted the fix/expression-validation branch October 25, 2026 03:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant