Skip to content

ci: verify executable permissions in packaged macOS prebuilds #1004

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Mike Hamanaka (hamanakam1) wants to merge 1 commit into
base: main
Choose a base branch
from
Open

ci: verify executable permissions in packaged macOS prebuilds #1004

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions publish.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,17 @@ extends:
# stable releases, but increments the version for beta releases.
- script: node scripts/increment-version.js
displayName: 'Increment version'
- bash: |
set -euo pipefail
package_dir="$(mktemp -d)"
npm pack --ignore-scripts --pack-destination "$package_dir" >/dev/null
package_file=("$package_dir"/*.tgz)
if ! tar -tvf "${package_file[0]}" | grep -Eq '^-rwxr-xr-x .*package/prebuilds/darwin-(arm64|x64)/spawn-helper$'; then
echo 'The published package must contain executable macOS spawn-helper binaries.' >&2
tar -tvf "${package_file[0]}" | grep 'spawn-helper' >&2 || true
exit 1
fi
displayName: 'Verify packaged spawn-helper permissions'

testSteps:
- task: DownloadPipelineArtifact@2
Expand All @@ -90,6 +101,17 @@ extends:
displayName: 'Test'
- script: npm run lint
displayName: 'Lint'
- bash: |
set -euo pipefail
package_dir="$(mktemp -d)"
npm pack --ignore-scripts --pack-destination "$package_dir" >/dev/null
package_file=("$package_dir"/*.tgz)
if ! tar -tvf "${package_file[0]}" | grep -Eq '^-rwxr-xr-x .*package/prebuilds/darwin-(arm64|x64)/spawn-helper$'; then
echo 'The published package must contain executable macOS spawn-helper binaries.' >&2
tar -tvf "${package_file[0]}" | grep 'spawn-helper' >&2 || true
exit 1
fi
displayName: 'Verify packaged spawn-helper permissions'

publishPackage: ${{ parameters.publishPackage }}
${{ if eq(variables['releaseQuality'], 'stable') }}:
Expand Down