Fix last-element indexing mixed with slices or scalar indices - #3056
Open
林SO (Linxiushen) wants to merge 1 commit into
Open
林SO (Linxiushen) wants to merge 1 commit into
林SO (Linxiushen) wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expressions such as
x[-1, :2],x[:2, -1], andx[-1, -1]currently lower the last-element index to an emptySlice(-1, 0)before squeezing that axis. This raises an error in both eager evaluation and exported ONNX modelsUse the axis end as the stop for scalar
-1: the known dimension length in eager mode and the converter's existing maximum-int64 bound for exported models. Add public@scriptregressions comparing values and shapes with NumPy across two symbolic input shapes, including mixed scalar indices, reverse slicing, and a positive-index controlValidation:
lintrunner -aon all three changed files andgit diff --check: passedThe full repository and Torch/GPU suites were not run. This change addresses last-element indexing mixed with slices or scalar indices; it does not address general advanced-index handling