[rush] Omit registry URLs from the bootstrap lockfile - #5963
Open
Jamie Magee (JamieMagee) wants to merge 1 commit into
Open
[rush] Omit registry URLs from the bootstrap lockfile#5963Jamie Magee (JamieMagee) wants to merge 1 commit into
Jamie Magee (JamieMagee) wants to merge 1 commit into
Conversation
Add the Rush npm setting and regenerate the validation lockfile through install-run-rush without changing its dependency graph. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The checked-in
install-run-rushlockfile records registry URLs from the package feed proxy. This addsomit-lockfile-registry-resolved=trueto the Rush npm configuration and removes those URLs fromcommon/config/validation/rush-package-lock.json.Details
install-run-rushcopiescommon/config/rush/.npmrcinto its temporary npm project before installing Rush. I regenerated the validation lockfile from that bootstrap project with npm 11.19.0 and the package feed proxy used by the post-publish pipeline.A fresh unseeded install selected newer transitive versions, so I rejected that output. To keep the existing dependency graph, I made a temporary copy of the current lockfile without
resolvedfields and seeded the bootstrapnpm installwith it. The intermediate file stayed outside the repository. The final lockfile matches the original structure after ignoringresolvedfields, so dependency versions, integrity hashes, lockfile version 3, and platform metadata are unchanged. The diff removes 397resolvedentries and adds the npm setting.How it was tested
node common/scripts/install-run-rush.js --helpwith an isolatedRUSH_TEMP_FOLDER; both outputs were byte-identical.install-run-rushwithINSTALL_RUN_RUSH_LOCKFILE_PATHpointing to the regenerated lockfile. Itsnpm cibootstrap completed successfully.npm config get omit-lockfile-registry-resolvedreturnstruein the bootstrap project.resolvedfields orpkgs.visualstudio.comURLs.node common/scripts/install-run-rush.js change --verify.node common/scripts/install-run-rush.js install --to repo-toolbox.node common/scripts/install-run-rush.js build --to repo-toolbox --verbose.rush prettiercheck passed.