Skip to content

Python: Build an array schema for variadic tuple parameters #14692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Anish Mehta (anishmehta24) wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Python: Build an array schema for variadic tuple parameters #14692

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions python/semantic_kernel/schema/kernel_json_schema_builder.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,8 +196,12 @@ def handle_complex_type(
schema["additionalProperties"] = False
return schema
if origin is tuple:
items = [cls.build(arg, structured_output=structured_output) for arg in args]
schema = {"type": "array", "items": items}
if len(args) == 2 and args[1] is Ellipsis:
# tuple[X, ...] holds any number of X, like list[X]
schema = {"type": "array", "items": cls.build(args[0], structured_output=structured_output)}
else:
items = [cls.build(arg, structured_output=structured_output) for arg in args]
schema = {"type": "array", "items": items}
if description:
schema["description"] = description
if structured_output:
Expand Down
10 changes: 10 additions & 0 deletions python/tests/unit/schema/test_schema_builder.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -241,6 +241,16 @@ def test_build_tuple():
}


def test_build_variadic_tuple():
schema = KernelJsonSchemaBuilder.build(tuple[int, ...], "ids")
assert schema == {"type": "array", "items": {"type": "integer"}, "description": "ids"}


def test_build_optional_variadic_tuple():
schema = KernelJsonSchemaBuilder.build(Optional[tuple[str, ...]])
assert schema == {"type": ["array", "null"], "items": {"type": "string"}}


def test_build_union():
schema = KernelJsonSchemaBuilder.build(Union[int, str])
assert schema == {"anyOf": [{"type": "integer"}, {"type": "string"}]}
Expand Down
Loading