Repository navigation
Python: preserve path case in OpenAPI allowed URLs - #14693
Open
Eduard van Valkenburg (eavanvalkenburg) wants to merge 1 commit into
Open
Eduard van Valkenburg (eavanvalkenburg) wants to merge 1 commit into
Eduard van Valkenburg (eavanvalkenburg) wants to merge 1 commit into
Conversation
Eduard van Valkenburg (eavanvalkenburg)
requested a review
from a team
as a code owner
October 30, 2026 15:02
Eduard van Valkenburg (eavanvalkenburg)
deployed
to
github-app-auth
October 30, 2026 15:02 — with
GitHub Actions
Active
Copilot started reviewing on behalf of
Eduard van Valkenburg (eavanvalkenburg)
October 30, 2026 15:02
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are reported for the change to case-sensitive allowed-base-URL path matching.
No open issues 🎉
What changed in this PR
This PR makes Python OpenAPI allowed-base-URL path matching case-sensitive while preserving existing scheme, host, effective-port, and slash-boundary behavior.
Changes:
- Remove lowercasing from exact-path and path-prefix comparisons.
- Add validator coverage for matching paths, descendants, case mismatches, and prefix boundaries.
- Add GET and POST coverage confirming rejected paths block both authentication and request dispatch.
| File | Description |
|---|---|
python/tests/unit/connectors/openapi_plugin/test_server_url_validator.py |
Tests case-sensitive path matching and prefix boundaries. |
python/tests/unit/connectors/openapi_plugin/test_openapi_runner.py |
Tests authentication and dispatch behavior for matching and mismatched path case. |
python/semantic_kernel/connectors/openapi_plugin/server_url_validator.py |
Preserves path case during allowed-URL comparisons. |
Review effort: Balanced
Darren Cohen (dargilco)
approved these changes
Oct 30, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
OpenAPI allowed base URLs can include a path prefix. URL paths are case-sensitive, so path-prefix matching must preserve case while the existing scheme, host, port, and slash-boundary behavior remains unchanged.
No linked issue.
Description
Validation:
cd python && uv run --python 3.12 pytest -q tests/unit/connectors/openapi_plugin/test_server_url_validator.py tests/unit/connectors/openapi_plugin/test_openapi_runner.py tests/unit/connectors/openapi_plugin/test_sk_openapi.py- passed.cd python && uv run --python 3.12 pre-commit run -a- passed.cd python && uv run --python 3.12 pytest tests/unit- not completed; collection stopped because the local environment does not include optional connector dependencies.Contribution Checklist