Repository navigation
Move saved analysis into Sources and fix empty-inventory warnings - #1909
Merged
Paul Lizer (paullizer) merged 1 commit intoNov 9, 2026
Conversation
Move saved analysis browsing out of classic and V2 answers while preserving evidence, follow-up actions, and genuine limitations. Use retained native coverage to distinguish complete empty comment inventories from missing evidence. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Paul Lizer (paullizer)
merged commit Nov 9, 2026
0245fc6
into
microsoft:Development
13 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Historical saved warnings are not rewritten or dismissed based on citation presence. This changes presentation and retained-result status projection, not document extraction, authorization, storage, or source re-analysis.
Linked issue
N/A - no associated issue was created for this work.
Release Notes & Latest Features
Is this visible to end users?
Is this admin-facing (Admin Settings, governance, deployment, config)?
Should this become a Latest Feature card?
Screenshot needed for the card?
Release notes were left unchanged pending maintainer confirmation. This is an existing-chat refinement, not a new Latest Feature card.
Version bump
application/single_app/config.pyVERSIONthird segment bumped, or not needed because this is docs-onlydeployers/version.txtbumped, or not needed becausedeployers/was not changedApplication version:
0.261.423->0.261.424. No deployer files changed.Testing / validation
Python test commands used this repository-root import setup:
python -m pytest .\functional_tests\test_orchestration_attachment_native_evidence.py .\functional_tests\test_orchestration_search_citations.py .\functional_tests\test_evidence_status.py -q --tb=short --junitxml=.\ui_tests\artifacts\saved-analysis\functional-results.xml- 116 passed.python -m pytest .\ui_tests\test_chat_saved_analysis.py .\ui_tests\test_v2_evidence_status.py -q --tb=short --junitxml=.\ui_tests\artifacts\saved-analysis\ui-results.xml- 96 passed. The final classic-specific DOM ownership correction was subsequently covered by the rerun below; V2 and evidence rendering were unchanged.python -m pytest .\ui_tests\test_chat_saved_analysis.py -k classic -q --tb=short --junitxml=.\ui_tests\artifacts\saved-analysis\classic-final-results.xml- 39 passed, including the additional answer-HTML ownership regression.npm --prefix .\application\v2_ui run typecheck- passed.npm --prefix .\application\v2_ui run build- passed.npm --prefix .\application\v2_ui run build -- --outDir ..\..\ui_tests\artifacts\saved-analysis- passed.node --check .\application\single_app\static\js\chat\chat-analysis-results.jsandnode --check .\application\single_app\static\js\chat\chat-messages.js- both passed after the final classic correction.python .\functional_tests\test_docs_app_surface_coverage.py- 7/7 checks passed; the regenerated inventory was semantically unchanged.python .\functional_tests\test_docs_site_quality.py- 6/6 checks passed.python .\scripts\check_cosmos_response_boundaries.py- passed, zero review gaps.git -c core.whitespace=blank-at-eol,blank-at-eof,space-before-tab,cr-at-eol --no-pager diff --check- passed.The repository XSS scanner's
inspect_filewas also run on the actual uncommitted added-line ranges: 10 application files, zero findings. Browser fixture inspection covered desktop/mobile, light/dark, keyboard access, lazy pagination/evidence, stream/history reload, masking, and cancellation. Full-file design-detector matches were reviewed as unchanged typing-dot animation and guarded dynamic-image/comment matches; no unrelated styling or suppressions were added.Validation uses the real retained-result readers and chat components with deterministic external transport. The signed-in live conversation and original file could not be independently inspected; this is not live Azure/model qualification.
Documentation
Updated the Analyze guide, chat-controls reference, saved-analysis feature documentation, and evidence-status documentation. Added
docs/explanation/fixes/CHAT_ANALYSIS_PRESENTATION_AND_EVIDENCE_FIX.mdwith root cause, compatibility boundaries, and validation results. Release notes remain deferred as noted above.Security checklist
@swagger_route(security=get_auth_security())sanitize_settings_for_user()The first two checks are N/A: no Flask routes or settings serialization were added or changed. Existing source/conversation authorization and retained-result integrity checks remain enforced. Test screenshots, reports, build outputs, and session artifacts are not committed.