fix: use compiler version for standalone CLI distribution versioning [skip chg] - #11157
fix: use compiler version for standalone CLI distribution versioning [skip chg]#11157timotheeguerin with Copilot wants to merge 7 commits into
Conversation
Co-authored-by: timotheeguerin <1031227+timotheeguerin@users.noreply.github.com>
|
@copilot wondering if instead we should just make sure the version match at all time and add standlone cli to the same version policy |
…version to 1.13.0 Co-authored-by: timotheeguerin <1031227+timotheeguerin@users.noreply.github.com>
Done. Moved |
microsoft-github-policy-service
Bot
added
the
stale
|
@copilot rebase |
…h main Co-authored-by: timotheeguerin <1031227+timotheeguerin@users.noreply.github.com>
Done — the branch is now synced with latest main (version bumped to |
|
@copilot there is sstill conflict, pull main and merge them |
Co-authored-by: timotheeguerin <1031227+timotheeguerin@users.noreply.github.com>
Done — merged main into the branch and resolved the two conflicts:
|
There was a problem hiding this comment.
@copilot because now the compiler is bundled in the standalone cli it does make sense that it is exactly the same version, should we do things differently to make sure hotfix are applied to both?
There was a problem hiding this comment.
Since @typespec/standalone-cli is now in the typespec-stable lockstep policy alongside @typespec/compiler, any version bump — including hotfix patch releases — will automatically apply to both packages at the same time. No additional changes are needed; the lockstep policy already guarantees they stay in sync for every release type.
There was a problem hiding this comment.
@copilot no the polcy only lock minor, they would diverge on patch. We probably just want to ignore the version of standalone cli (remove from versioning all together
There was a problem hiding this comment.
Done in 4cdde5b. Removed @typespec/standalone-cli from the typespec-stable version policy entirely — its version won't be managed by Chronus at all, so it can never diverge from the compiler on patch releases.
There was a problem hiding this comment.
@copilot we also ened to update the version retrieval logic to fetch it from the compiler package.json...
There was a problem hiding this comment.
Done in a9f70cb. The pipeline now reads the version from packages/compiler/package.json so latest.txt and blob storage paths always reflect the compiler version.
|
You can try these changes here
|
timotheeguerin
changed the title
| @@ -0,0 +1,7 @@ | |||
| --- | |||
| changeKind: fix | |||
There was a problem hiding this comment.
| changeKind: fix | |
| changeKind: internal |
There was a problem hiding this comment.
Applied in 4cdde5b.
…internal Co-authored-by: timotheeguerin <1031227+timotheeguerin@users.noreply.github.com>
Co-authored-by: timotheeguerin <1031227+timotheeguerin@users.noreply.github.com>
@typespec/standalone-clifollows a different version scheme (0.83.0) than@typespec/compiler(1.13.0). The publish pipeline was writing the standalone package version tolatest.txtand blob storage paths, whiletsp --versionreports the compiler version — causing Scoop/winget/Homebrew listings to show a version users never see.Changes
eng/tsp-core/pipelines/jobs/cli/publish-artifacts.yml: ChangedworkingDirectoryfor the version-reading step frompackages/standalone→packages/compiler, solatest.txtand blob storage paths use the compiler version consistently withtsp --versionoutput.