Update C# client emitter TCGC dependency to 0.71.2 - #11748
Open
Dapeng Zhang (ArcturusZhang) wants to merge 1 commit into
Open
Update C# client emitter TCGC dependency to 0.71.2#11748Dapeng Zhang (ArcturusZhang) wants to merge 1 commit into
Dapeng Zhang (ArcturusZhang) wants to merge 1 commit into
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Dapeng Zhang (ArcturusZhang)
marked this pull request as ready for review
August 24, 2026 08:48
Copilot started reviewing on behalf of
Dapeng Zhang (ArcturusZhang)
August 24, 2026 08:49
View session
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the C# client emitter to TCGC 0.71.2 and adapts affected test fixtures.
Changes:
- Updates TCGC dependency ranges and lockfile.
- Scopes
@convenientAPIfixtures to C#. - Adds a Chronus dependency entry.
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
packages/http-client-csharp/package.json |
Updates TCGC dependency constraints. |
packages/http-client-csharp/package-lock.json |
Locks TCGC 0.71.2. |
packages/http-client-csharp/emitter/test/Unit/usage.test.ts |
Scopes convenience API fixtures to C#. |
packages/http-client-csharp/emitter/test/Unit/operation-paging.test.ts |
Scopes paging fixtures to C#. |
.chronus/changes/deps-csharp-tcgc-0.71.2-2026-08-24.md |
Records the dependency update. |
Files not reviewed (1)
- packages/http-client-csharp/package-lock.json: Generated file
Suppressed comments (2)
packages/http-client-csharp/emitter/test/Unit/usage.test.ts:636
@protocolAPI(false)is still unscoped at lines 617 and 623 in this same TCGC fixture. In 0.71.2,decorator-requires-scopeapplies to@protocolAPIas well as@convenientAPI, so this compile still emits validation diagnostics even though these adjacent convenience decorators are scoped. Please change both calls to@protocolAPI(false, "csharp").
@convenientAPI(false, "csharp")
packages/http-client-csharp/package.json:75
- The C# generator fixtures are not covered by this scoping update:
generator/TestProjects/Local/Sample-TypeSpec/Sample-TypeSpec.tspandgenerator/TestProjects/Plugin/Sample-TypeSpec/Sample-TypeSpec.tspstill contain unscoped@convenientAPI(true/false)calls (and unscoped@protocolAPI(false)). TCGC 0.71.2 requires these decorators to carry the"csharp"scope, so the generator inputs still producedecorator-requires-scopediagnostics. Please update those fixtures before accepting the dependency bump.
"@azure-tools/typespec-client-generator-core": "0.71.2",
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
You can try these changes here
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@convenientAPItest fixtures to C# for the new TCGC validationValidation
npm installeng/scripts/Generate.ps1npm run buildnpm run test:emitter(239 passed, 2 skipped)npm run test:generatornpm run copnpm run lint -- --emittercannot complete because the current script forwards an unsupported--emitteroption to ESLint; plainnpm run lintalso reports that this package has no ESLint configuration. Rootpnpm formatencounters existing TypeSpec parser errors outside this change; all unrelated formatter changes were restored.