Skip to content

Update C# client emitter TCGC dependency to 0.71.2 - #11748

Open
Dapeng Zhang (ArcturusZhang) wants to merge 1 commit into
microsoft:mainfrom
ArcturusZhang:deps/csharp-tcgc-0.71.2
Open

Update C# client emitter TCGC dependency to 0.71.2#11748
Dapeng Zhang (ArcturusZhang) wants to merge 1 commit into
microsoft:mainfrom
ArcturusZhang:deps/csharp-tcgc-0.71.2

Conversation

@ArcturusZhang

Copy link
Copy Markdown
Member

Summary

  • update the C# client emitter TCGC dev dependency and peer lower bound to 0.71.2
  • scope affected @convenientAPI test fixtures to C# for the new TCGC validation
  • add a Chronus dependency entry

Validation

  • npm install
  • eng/scripts/Generate.ps1
  • npm run build
  • npm run test:emitter (239 passed, 2 skipped)
  • npm run test:generator
  • npm run cop
  • changed files pass Prettier

npm run lint -- --emitter cannot complete because the current script forwards an unsupported --emitter option to ESLint; plain npm run lint also reports that this package has no ESLint configuration. Root pnpm format encounters existing TypeSpec parser errors outside this change; all unrelated formatter changes were restored.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the C# client emitter to TCGC 0.71.2 and adapts affected test fixtures.

Changes:

  • Updates TCGC dependency ranges and lockfile.
  • Scopes @convenientAPI fixtures to C#.
  • Adds a Chronus dependency entry.

Reviewed changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
packages/http-client-csharp/package.json Updates TCGC dependency constraints.
packages/http-client-csharp/package-lock.json Locks TCGC 0.71.2.
packages/http-client-csharp/emitter/test/Unit/usage.test.ts Scopes convenience API fixtures to C#.
packages/http-client-csharp/emitter/test/Unit/operation-paging.test.ts Scopes paging fixtures to C#.
.chronus/changes/deps-csharp-tcgc-0.71.2-2026-08-24.md Records the dependency update.
Files not reviewed (1)
  • packages/http-client-csharp/package-lock.json: Generated file
Suppressed comments (2)

packages/http-client-csharp/emitter/test/Unit/usage.test.ts:636

  • @protocolAPI(false) is still unscoped at lines 617 and 623 in this same TCGC fixture. In 0.71.2, decorator-requires-scope applies to @protocolAPI as well as @convenientAPI, so this compile still emits validation diagnostics even though these adjacent convenience decorators are scoped. Please change both calls to @protocolAPI(false, "csharp").
    @convenientAPI(false, "csharp")

packages/http-client-csharp/package.json:75

  • The C# generator fixtures are not covered by this scoping update: generator/TestProjects/Local/Sample-TypeSpec/Sample-TypeSpec.tsp and generator/TestProjects/Plugin/Sample-TypeSpec/Sample-TypeSpec.tsp still contain unscoped @convenientAPI(true/false) calls (and unscoped @protocolAPI(false)). TCGC 0.71.2 requires these decorators to carry the "csharp" scope, so the generator inputs still produce decorator-requires-scope diagnostics. Please update those fixtures before accepting the dependency bump.
    "@azure-tools/typespec-client-generator-core": "0.71.2",

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@azure-sdk-automation

azure-sdk-automation Bot commented Aug 24, 2026

Copy link
Copy Markdown

You can try these changes here

🛝 Playground 🌐 Website 🛝 VSCode Extension

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

emitter:client:csharp Issue for the C# client emitter: @typespec/http-client-csharp

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants