send telemetry for language client errors#14577
Open
bobbrow wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds telemetry for vscode-languageclient error callbacks in the C/C++ extension’s Language Server client, with the goal of distinguishing routine disconnect/error conditions from genuine language server crashes (to reduce misleading crash telemetry).
Changes:
- Emit a new
C_Cpp/LanguageServer/languageClientErrortelemetry event from the language clienterrorHandler.errorcallback. - Include basic error context (
error,message,count) in the telemetry payload.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+1758
to
+1765
| error: (error, message, count) => { | ||
| telemetry.logLanguageServerEvent("languageClientError", { | ||
| error: error.toString(), | ||
| message: message?.toString() ?? '', | ||
| count: count?.toString() ?? '' | ||
| }); | ||
| return { action: ErrorAction.Continue }; | ||
| }, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am seeing languageClientCrash telemetry in cases where I suspect a crash in cpptools has not actually happened. The logs show cpptools.exe being orphaned in some cases. I'm hoping this will give us some insight into what is breaking the connection so we can stop sending the crash telemetry for routine disconnect cases.