Add support for workspace read requests - #1825
Open
Mark Sujew (msujew) wants to merge 2 commits into
Open
Conversation
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
Author
|
@microsoft-github-policy-service agree |
Mark Sujew (msujew)
force-pushed
the
workspace-read-feature
branch
from
July 22, 2026 10:10
a97888f to
d0e4f81
Compare
Dirk Bäumer (dbaeumer)
requested changes
Aug 10, 2026
Dirk Bäumer (dbaeumer)
left a comment
Member
There was a problem hiding this comment.
Thanks. Very nice PR.
| /** | ||
| * Whether the file is a symbolic link. | ||
| */ | ||
| isSymlink: boolean; |
There was a problem hiding this comment.
Can we make this a flag property with a bit wise implementation. Makes it easier to expand in the future.
Author
There was a problem hiding this comment.
I thought about combining it with the type property, similar to how its done in vscode, but decided against it. Is this what you had in mind?
| /** | ||
| * Whether the entry is a symbolic link. | ||
| */ | ||
| isSymlink: boolean; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to microsoft/language-server-protocol#1264 (does not fully resolve it, since this PR does not include features to write into a file system - only read from it).
Adds support for the server to read files/directories/stat info from the client.
As indicated by microsoft/language-server-protocol#1264 (comment), I also thought it'd be best to start with read-only access to the file system. However, the new interfaces/types should be extendable enough to also add write requests if required later on.
Some questions/considerations:
null. Should it return a response error instead?FileSystemClientCapabilities. Does it make sense to expose each individual request type as an opt-in flag? Or is it enough to provide aread?: booleanflag (maybe extend this with awrite?: booleanflag later on)?FileType.unknownvalue results from the fact that vscode offersvscode.FileType.unknownas a possible value to return forFileStat.type. Should this be included in the protocol, or should stats/directory entries with this type simply be omitted?