Repository navigation
Do not send params for notifications without parameters - #1945
Open
Ilya Trapashko (itrapashko) wants to merge 1 commit into
Open
Ilya Trapashko (itrapashko) wants to merge 1 commit into
Ilya Trapashko (itrapashko) wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues remain for the change preserving omitted notification parameters.
No open issues 🎉
What changed in this PR
Fixes #1944 by preserving omitted notification parameters in the server connection wrapper, preventing parameterless notifications from being sent with params: [null].
Changes:
- Forward only supplied notification arguments, matching the
sendRequestwrapper. - Preserve existing behavior for explicitly passed
undefined. - Add a regression test confirming that parameterless notifications deliver zero arguments.
| File | Description |
|---|---|
server/src/node/test/connection.test.ts |
Adds regression coverage for notifications without parameters. |
server/src/common/server.ts |
Uses an optional rest tuple to preserve the number of supplied arguments. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1944
The wrapper now forwards only the parameters that were actually passed, as
sendRequestdoes.[any?]is used instead ofany[]so that the spread matches the(method)and(method, params)overloads ofProtocolConnection.A notification with an explicit
undefinedparameter (e.g.NotificationType<void>) is still sent as[null].