Add missing window.title completion items#323456
Open
NaufalK25 wants to merge 2 commits into
Open
Conversation
${activeEditorLanguageId}, ${profileName}, and ${focusedView} are
documented in the window.title setting description and resolved at
runtime in windowTitle.ts, but were never added to the suggestion
list in settingsDocumentHelper.ts.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the configuration-editing extension’s settings.json IntelliSense for the window.title setting so the completion list includes all variables that are already documented and supported at runtime.
Changes:
- Add
${activeEditorLanguageId}to thewindow.titlecompletion items. - Add
${profileName}to thewindow.titlecompletion items. - Add
${focusedView}to thewindow.titlecompletion items.
Guards against any window.title variable silently disappearing from the suggestion list - not just the three added in the previous commit, but all of them, since none of the existing tests checked for variable presence.
Author
|
@microsoft-github-policy-service agree |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
${activeEditorLanguageId}, ${profileName}, and ${focusedView} are documented in the
window.titlesetting description workbench.contribution.ts and resolved at runtime in windowTitle.ts, but were missing from the completion list in settingsDocumentHelper.ts, so they never showed up as IntelliSense suggestions when editingwindow.titlein settings.json.This adds the three missing entries so the suggestion list matches the full
set of variables the setting actually supports.
Verified manually: built from source, opened settings.json, and confirmed all
three now appear via Ctrl+Space inside the
window.titlestring value.