Skip to content

sessions: Preserve editor and inactive tab styling - #330861

Merged
Sandeep Somavarapu (sandy081) merged 3 commits into
mainfrom
sandy081/agents/modern-ui-tabs-ccr
Aug 14, 2026
Merged

sessions: Preserve editor and inactive tab styling#330861
Sandeep Somavarapu (sandy081) merged 3 commits into
mainfrom
sandy081/agents/modern-ui-tabs-ccr

Conversation

@sandy081

Copy link
Copy Markdown
Member

Summary

Follow-up to #330858 addressing Copilot Code Review feedback:

  • keep reusable hook sizing and line-height declarations off canonical editor-tab selectors
  • restore focused/unfocused chat-tab colors for side-by-side session views
  • restore focused/unfocused close-action overlay colors
  • update the detailed Sessions layout ownership contract
  • test the shared host active-state contract

Editor-tab compatibility

A declaration-level comparison verified all 154 canonical .part.editor tab selectors match the pre-#330858 baseline exactly. The reusable hook keeps its fallback sizing in hook-only rules, so compact and regular editor tabs are unchanged.

Validation

  • npm run compile
  • npm run hygiene
  • ./scripts/test.sh --grep "Sessions - (ChatCompositeBar|Session View)" (7 passing)
  • targeted stylelint
  • runtime focused/unfocused fill, foreground, and close-overlay checks

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot AI balanced review requested due to automatic review settings August 14, 2026 13:56
@sandy081 Sandeep Somavarapu (sandy081) added this to the 1.134.0 milestone Aug 14, 2026
@vs-code-engineering

vs-code-engineering Bot commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

📬 CODENOTIFY

The following users are being notified based on files changed in this PR:

Benjamin Christopher Simmonds (@benibenj)

Matched files:

  • src/vs/sessions/browser/parts/media/chatCompositeBar.css
  • src/vs/sessions/browser/parts/sessionBarStyles.ts
  • src/vs/sessions/browser/parts/sessionView.ts

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Preserves canonical editor-tab styling while restoring focused and unfocused Sessions tab presentation.

Changes:

  • Isolates reusable tab sizing from canonical editor selectors.
  • Adds active-session styling and close-overlay states.
  • Documents and tests the shared active-state contract.
Show a summary per file
File Description
tabs.css Adds focus-aware shared tab selectors.
sessionView.ts Exposes active state through CSS classes.
chatCompositeBar.css Restores action-overlay state colors.
sessionView.test.ts Tests active-state class toggling.
LAYOUT.md Updates shared styling ownership.

Review details

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

  • Files reviewed: 5/5 changed files
  • Comments generated: 2
  • Review effort level: Balanced

Comment thread src/vs/sessions/LAYOUT.md Outdated
Comment thread src/vs/sessions/browser/parts/media/chatCompositeBar.css
Recompute tab action overlays against each session surface and document the current tab-strip visibility behavior.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@sandy081
Sandeep Somavarapu (sandy081) merged commit d144109 into main Aug 14, 2026
27 checks passed
@sandy081
Sandeep Somavarapu (sandy081) deleted the sandy081/agents/modern-ui-tabs-ccr branch August 14, 2026 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants