Fixes #319956: Enable editor.showUnused for .js files - #330867
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Restores unused-code highlighting in unconfigured JavaScript files by preserving an unset checkJs value.
Changes:
- Makes
checkJsoptional. - Distinguishes explicit configuration from the default value.
Show a summary per file
| File | Description |
|---|---|
extensions/typescript-language-features/src/configuration/configuration.ts |
Preserves undefined when checkJs is not explicitly configured. |
Review details
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Balanced
Ulugbek Abdullaev (ulugbekna)
approved these changes
Aug 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The changes address the issue where unused code in JavaScript files was not being grayed out. The implementation updates the handling of the
checkJsconfiguration to ensure it can be properly read and utilized. Testing can be done by creating a new.jsfile with unused code and verifying that the unused code appears grayed out in the editor.