Test pdf1.5 - #220
Merged
Merged
Test pdf1.5#220
Conversation
There was a problem hiding this comment.
Copilot review overview
🔵 Needs a closer look
Retain stable contextual MindeePdfException messages instead of exposing dependency-specific parser text.
Review effort: Lite
Findings: None
What changed in this PR
Adds PDF 1.5/object-stream test coverage, standardizes test variable names, and updates PDF exception handling.
Changes:
- Adds
object_streams.pdffunctional coverage. - Renames input variables across tests.
- Updates PDF exception messages.
| File | Reviewed changes |
|---|---|
tests/V2/ClientV2TestFunctional.php |
Updates functional PDF coverage and input naming. |
tests/V2/ClientV2Test.php |
Renames a test input variable. |
tests/Input/UrlInputSourceTest.php |
Renames URL input variables. |
tests/Input/LocalInputSourceTest.php |
Renames local input variables and a test method. |
src/Input/LocalInputSource.php |
Updates PDF exception messages and constructor placement; stable contextual messages should be retained. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Types of changes