Repository navigation
Upgrade dependencies and Gradle wrapper - #1727
Conversation
- Gradle wrapper 9.7.1 -> 9.8.2 - spotbugs plugin 6.5.11 -> 6.5.13 (SpotBugs 4.10.5), spotless 8.10.2 -> 8.10.4 - guava 33.7.2-jre, okhttp/mockwebserver 5.5.1, jackson 2.21.8, bcprov-jdk18on 1.86, commons-codec 1.23.0, snappy-java 1.1.10.12, spotbugs-annotations 4.10.5 (also in CI) - Suppress MC_OVERRIDABLE_METHOD_CALL_IN_CONSTRUCTOR, newly reported by SpotBugs 4.10.5, for the existing public classes it flags Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review.
|
| Layer / File(s) | Summary |
|---|---|
Build and test tooling versions build.gradle, gradle/wrapper/gradle-wrapper.properties, .github/workflows/gradle.yml, spotbugs-filter.xml |
Gradle, plugin, and dependency versions are updated. CI uses SpotBugs annotations 4.10.5. The SpotBugs filter excludes MC_OVERRIDABLE_METHOD_CALL_IN_CONSTRUCTOR for five classes. |
Windows wrapper startup and error handling gradlew.bat |
The batch wrapper adds a safety-net jump. Java discovery errors print to stderr and jump to the error-exit label. The Gradle launch path also calls that label. |
Priority:
Estimated code review effort: 2 (Simple) | ~12 minutes
Change: Other
Possibly related issues
- Issue 1725 requests a release with a Bouncy Castle update for two CVEs. This pull request updates Bouncy Castle to 1.86, but the available information does not establish whether it satisfies the requested release.
Possibly related PRs
- minio/minio-java#1726: Both pull requests update Guava and Snappy Java dependency declarations.
Merge Risk: 
Minimal · up to cb504
-
The maintenance updates have no identified merge-blocking issue. Merge after normal build and Windows wrapper checks pass.
Pre-merge checks: 
5
-
Full details: Title check
-
Explanation
The title "Upgrade dependencies and Gradle wrapper" matches the main change. The PR updates the Gradle wrapper from 9.7.1 to 9.8.2, the SpotBugs and Spotless plugins, and several library dependencies. The title is short and specific, and a teammate scanning history would understand the primary change.
Full details: Docstring Coverage
-
Explanation
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (5 skipped: 5 unsupported.)
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
A rabbit checks the wrapper’s trail,
And finds the error path set right.
New versions hop into the build,
SpotBugs gets a filter, too.
The test classpaths follow along,
Then quiet paws review the change.
Comment @coderabbitai help to get the list of available commands.
Summary
Notes
MC_OVERRIDABLE_METHOD_CALL_IN_CONSTRUCTORinHttp.Headers,Http.QueryParameters,AssumeRoleProvider,CertificateIdentityProviderandLdapIdentityProvider. The suppression inspotbugs-filter.xmlcovers only those classes; making the methodsfinalwould break subclasses of public API.Test plan
./gradlew build./gradlew build -Prelease🤖 Generated with Claude Code
Summary by CodeRabbit