Skip to content

Upgrade dependencies and Gradle wrapper - #1727

Merged
harshavardhana merged 1 commit into
minio:masterfrom
balamurugana:upgrade-dependencies
Oct 30, 2026
Merged

harshavardhana merged 1 commit into
minio:masterfrom
balamurugana:upgrade-dependencies

Conversation

@balamurugana

@balamurugana balamurugana commented Oct 30, 2026 •

Copy link
Copy Markdown
Member

Summary

  • Gradle wrapper 9.7.1 → 9.8.2
  • Gradle plugins: spotbugs 6.5.11 → 6.5.13 (SpotBugs 4.10.5), spotless 8.10.2 → 8.10.4
  • Libraries: guava 33.7.2-jre, okhttp/mockwebserver 5.5.1, jackson 2.21.8, bcprov-jdk18on 1.86, commons-codec 1.23.0, snappy-java 1.1.10.12, spotbugs-annotations 4.10.5 (also updated in the CI functional test steps)
  • All upgraded library jars still target Java 8 bytecode.

Notes

  • SpotBugs 4.10.5 newly reports MC_OVERRIDABLE_METHOD_CALL_IN_CONSTRUCTOR in Http.Headers, Http.QueryParameters, AssumeRoleProvider, CertificateIdentityProvider and LdapIdentityProvider. The suppression in spotbugs-filter.xml covers only those classes; making the methods final would break subclasses of public API.
  • Intentionally not upgraded:
    • Jackson stays on the 2.21 LTS line.
    • JUnit stays on 5.14.x because JUnit 6 requires Java 17 and functional tests run on Java 8/11.
    • google-java-format stays on 1.36.1 because 1.37.0 inserts blank lines between import groups across the codebase.
  • GitHub Actions (checkout v7, setup-java v6, codeql-action v4) are already on their latest major versions.

Test plan

  • ./gradlew build
  • ./gradlew build -Prelease

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Chores
    • Updated the project’s build tools and supporting libraries to newer versions.
  • Bug Fixes
    • Improved Windows startup error handling: Java discovery failures are reported to standard error and exit cleanly. Older launch scripts can also reach the existing error-exit path.
  • Other
    • No end-user features or application behavior changes are included.

- Gradle wrapper 9.7.1 -> 9.8.2
- spotbugs plugin 6.5.11 -> 6.5.13 (SpotBugs 4.10.5), spotless 8.10.2 -> 8.10.4
- guava 33.7.2-jre, okhttp/mockwebserver 5.5.1, jackson 2.21.8,
  bcprov-jdk18on 1.86, commons-codec 1.23.0, snappy-java 1.1.10.12,
  spotbugs-annotations 4.10.5 (also in CI)
- Suppress MC_OVERRIDABLE_METHOD_CALL_IN_CONSTRUCTOR, newly reported by
  SpotBugs 4.10.5, for the existing public classes it flags

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Oct 30, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 5bc4a5e7-14bc-48ca-bc22-853a4db7354d
Commits

Reviewing files that changed from the base of the PR and between a2bad3e and cb504b1.

Files ignored due to path filters: 1
  • gradle/wrapper/gradle-wrapper.jar is excluded by !**/*.jar
Files selected for processing: 5
  • .github/workflows/gradle.yml
  • build.gradle
  • gradle/wrapper/gradle-wrapper.properties
  • gradlew.bat
  • spotbugs-filter.xml

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 3 remain after this review.

Walkthrough

The pull request updates Gradle, plugin, and dependency versions; aligns CI test classpaths with the new SpotBugs annotations version; adds a SpotBugs exclusion; and changes error handling in the Windows Gradle wrapper.

Changes: Gradle maintenance

Layer / File(s) Summary
Build and test tooling versions
build.gradle, gradle/wrapper/gradle-wrapper.properties, .github/workflows/gradle.yml, spotbugs-filter.xml
Gradle, plugin, and dependency versions are updated. CI uses SpotBugs annotations 4.10.5. The SpotBugs filter excludes MC_OVERRIDABLE_METHOD_CALL_IN_CONSTRUCTOR for five classes.
Windows wrapper startup and error handling
gradlew.bat
The batch wrapper adds a safety-net jump. Java discovery errors print to stderr and jump to the error-exit label. The Gradle launch path also calls that label.

Priority: Low

Estimated code review effort: 2 (Simple) | ~12 minutes

Change: Other

Possibly related issues

  • Issue 1725 requests a release with a Bouncy Castle update for two CVEs. This pull request updates Bouncy Castle to 1.86, but the available information does not establish whether it satisfies the requested release.

Possibly related PRs

Merge Risk: Minimal · up to cb504

The maintenance updates have no identified merge-blocking issue. Merge after normal build and Windows wrapper checks pass.

Pre-merge checks: Passed 5
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title "Upgrade dependencies and Gradle wrapper" matches the main change. The PR updates the Gradle wrapper from 9.7.1 to 9.8.2, the SpotBugs and Spotless plugins, and several library dependencies.…
Docstring Coverage Passed No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title "Upgrade dependencies and Gradle wrapper" matches the main change. The PR updates the Gradle wrapper from 9.7.1 to 9.8.2, the SpotBugs and Spotless plugins, and several library dependencies. The title is short and specific, and a teammate scanning history would understand the primary change.

Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (5 skipped: 5 unsupported.)

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

A rabbit checks the wrapper’s trail,
And finds the error path set right.
New versions hop into the build,
SpotBugs gets a filter, too.
The test classpaths follow along,
Then quiet paws review the change.

Comment @coderabbitai help to get the list of available commands.

@harshavardhana
harshavardhana merged commit 7c04791 into minio:master Oct 30, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants