ci: fix release_linux workflow - #2124
Merged
Merged
Conversation
- remove the comments-only top-level env block (null value, rejected by the workflow parser: 'Unexpected value ""' at line 21) - drop the duplicated job-level permissions key (line 33: 'permissions is already defined') Both came in with the packaging pipeline commits; every push to master and to the mempool-rest-proxy / pos-seal-indexing branches since Sep 20 failed at startup because of this, including the merges of #2121 and #2122. No job ever ran; nothing else is affected.
nullPointerEnjoyer
requested review from
ImplOfAnImpl,
anyxem and
erubboli
as code owners
September 22, 2026 07:51
|
✅ OpenCodeReview: Review complete: 0 finding(s) across 1 selected item(s). |
erubboli
approved these changes
Sep 22, 2026
The note about container image pins was left as a top-level comment when the empty env block was removed, where it documented nothing. Move it onto the Create RPM packages step, the first consumer of the pins; the deb step's existing comment already covers the test-local.sh part.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Every push since the packaging pipeline commits (Sep 20) fails
.github/workflows/release_linux.ymlat startup — including the merges of #2121 and #2122. No job ever runs; GitHub reports:Cause
Two independent workflow-file bugs, both introduced while the packaging PR findings were being addressed (c280735 / 403be7a):
env:block containing only comments → the value parses asnull, which the workflow parser rejects.permissions:key — one block per commit, merged together.Fix
env:block into a plain comment (same text).permissions:block.Verification
.github/workflows/scanned with the same check and already OK.release_linuxrun should get past startup and actually create the build jobs.