Repository navigation
docs: document review with a protected deployment branch - #8401
Merged
Merged
Conversation
Contributor
Author
|
Preview deployment for your docs. Learn more about Mintlify Previews.
💡 Tip: Enable Automations to automatically generate PRs for you. |
hunterchen7
approved these changes
Nov 11, 2026
Merged
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explains that Require review before publishing now works with a protected deployment branch on GitHub.com, how reviews and GitHub approvals work there, and that admins can't skip review in that case.
Based on merged editor and server changes that connect GitHub branch protection to editor branch reviews.
Note
Low Risk
Documentation-only updates with no application or security logic changes.
Overview
Updates editor and roles docs so Require review before publishing is described as compatible with a protected deployment branch on GitHub.com, replacing guidance that blocked turning the setting on when the deploy branch is protected.
The docs now spell out the protected-branch workflow (Create branch → Request review → editor Approve → Publish approved changes), add a publish-matrix row for that case, and clarify that admins cannot bypass review when the deployment branch is protected. They also document GitHub PR review visibility in the inbox (reference only), editor approvals syncing to GitHub when accounts are connected, and that GitHub-only approvals do not count in the editor. GitHub Enterprise Server with a protected deploy branch remains unsupported for this setting.
Reviewed by Cursor Bugbot for commit d038307. Bugbot is set up for automated code reviews on this repo. Configure here.