Conversation
TableWrapper.bulkPut ran its work inside an async Promise executor with no reject, so a rejected chunk write settled the executor's own promise rather than the returned one. The promise never settled at all. SearchService's cold-cache path waits on it behind `while (!searchServiceIsLoaded)`, so the parsing spinner stays up for good, and the .catch already written for that path in index.js could not run because nothing ever rejected. Signed-off-by: ppcvote <risky9763@gmail.com>
Signed-off-by: ppcvote <risky9763@gmail.com>
A failed cold start left searchServiceIsLoaded false, and `search` waits on that flag in a loop, so every query after the failure re-showed the parsing icon every 100ms for as long as the page stayed open. The warm restore path had the opposite problem: its `finally` set the flag to true unconditionally, overriding the false its own `catch` had just set, so a failed restore reported success and then queried a SearchService that never initialized. Both paths now put the controls into the same unavailable state the unsupported browser branch already used, which that branch now shares, and `search` stops waiting once the index is known not to be coming. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
The two tests added with the fix both drive the cold-start branch. This adds one for the cached branch, where the `finally` used to override the `catch`, so both halves of the change have a test that fails without it. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
fix: update search filtering to give more accurate results
fix(search): bulkPut hangs instead of rejecting when an IndexedDB write fails
… and sidebar loading fix
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix search and add dark mode