Drop the retrieval-eval database too, which the test-job cleanup did not cover - #682
Merged
Conversation
…not cover retrieval-eval builds its OWN run-scoped database via DEV_DB_NAME and never dropped it. The cleanup added in PR 681 covered only the ExUnit database, so every eval run left a loopctl_ci_eval_<run id> behind on the shared CI instance for the reaper to find two days later. Counted on beelink just now: 64 of them. Same shape as the miss in ecommerce-friendly PR 101, and worth naming as a pattern rather than two coincidences. When the CI port and the run-scoped NAME were rolled out, they were applied to every job that creates a database; the DROP was applied to the obvious one. The gap does not show up in a diff - both files look complete - it shows up as a count on the server, which is the only place I found either of them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
retrieval-evalbuilds its own run-scoped database viaDEV_DB_NAMEand never dropped it. The cleanup added in #681 covered only the ExUnit database, so every eval run left aloopctl_ci_eval_<run id>behind on the shared CI instance for the reaper to find two days later.Counted on beelink just now: 64 of them.
Worth naming as a pattern, not two coincidences
This is the same shape as ecommerce-friendly#101, found the same way. When the CI port and the run-scoped name were rolled out, they went onto every job that creates a database. The drop went onto the obvious one.
The gap does not show up in a diff — both workflows look complete. It shows up as a count on the server, which is the only place either was found:
The generalisable check, for any repo adopting end-of-job cleanup: enumerate jobs whose
envnames a database, and assert each has a drop step. Two of five jobs across two repos failed that check after their cleanup PRs merged green.Reviewed inline (this session cannot dispatch agents/workflows) per the CLAUDE.md gate clause.