Re-introduce Array API Tests suite - #4433
Conversation
Signed-off-by: Pradyot Ranjan <99216956+pradyotRanjan@users.noreply.github.com>
|
Please allow gh-action runs for this PR so we can see failures in CI. |
|
CC @ev-br |
ev-br
left a comment
There was a problem hiding this comment.
One small suggestion below.
The first run is expected to have a few failures. Once we see them, we'll be able to produce a set of relevant skips.
Signed-off-by: Pradyot Ranjan <99216956+pradyotRanjan@users.noreply.github.com>
…/mlx into full-tests-compatability
|
@ev-br We need to address this PR data-apis/array-api-tests#459 See error log in CI |
|
Ah yes. Let's continue on the array-api-tests PR |
Signed-off-by: Pradyot Ranjan <99216956+pradyotRanjan@users.noreply.github.com>
…/mlx into full-tests-compatability
|
@ev-br The test suite now runs. Thanks! I've tried adding a skip file in the latest commit (which may not be accurate, as I used AI to generate it); let's wait for another CI run. |
|
Thanks for the ping @prady0t! IMO the tentative skips file shows that the compatibility level is very high. To explain some context, which might not be immediately clear for those who do not deal with the Array API test suite regularly:
Having a non-empty skips file is actually expected: for example, here are skipfiles for jax, numpy and ndoonx. Quickly looking through the skips this PR adds, several classes of failures might be somewhat lower priority:
We could certainly refactor the xfails file to visually group failures. |
|
Can we have another CI run for this PR? |
Following #3526, we are in a much better shape to re-introduce the array-api-tests in CI.