Fix fx_cut frames missing producer meta. and set. properties - #1298
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Producer properties are propagated only after attached filters run, leaving filters unable to consume them during processing.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Extracts producer frame-property propagation into public C/C++ APIs and applies it to fx_cut playlist frames.
Changes:
- Adds and exports
mlt_producer_pass_frame_properties(). - Propagates parent and cut properties in the
fx_cutpath. - Adds playlist and tractor regression tests.
File summaries
| File | Description |
|---|---|
AGENTS.md |
Documents symbol-export requirements. |
NEWS |
Records the new behavior and API. |
src/framework/mlt_playlist.c |
Propagates properties to fx_cut frames. |
src/framework/mlt_producer.c |
Extracts property propagation logic. |
src/framework/mlt_producer.h |
Declares the public C API. |
src/framework/mlt.vers |
Exports the C symbol. |
src/mlt++/MltProducer.cpp |
Implements the C++ wrapper. |
src/mlt++/MltProducer.h |
Declares the wrapper method. |
src/mlt++/mlt++.vers |
Exports the C++ symbol. |
src/tests/test_playlist/test_playlist.cpp |
Tests fx_cut frame properties. |
src/tests/test_tractor/test_tractor.cpp |
Tests metadata reaching tractor output. |
Review details
- Files reviewed: 11/11 changed files
- Comments generated: 2
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Playlist fx_cut skips producer_get_frame(), so producer annotations never reached tractor output. Extract mlt_producer_pass_frame_properties() and use it from both producer_get_frame and the fx_cut path.
Match producer_get_frame order: parent meta, parent filters, cut meta, cut filters, so filter_process can read meta.media.* on the frame.
ddennedy
force-pushed
the
fix-fx-cut-meta
branch
from
September 12, 2026 19:44
087adc0 to
8825ea2
Compare
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The new public C++ API behavior and release-note API list need documentation corrections.
Get a fresh assessment by requesting another Copilot review.
Review details
- Files reviewed: 11/11 changed files
- Comments generated: 2
- Review effort level: Balanced
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Playlist fx_cut skips producer_get_frame(), so producer annotations never reached tractor output. Extract
mlt_producer_pass_frame_properties()and use it from bothproducer_get_frameand the fx_cut path.