create overview on where and how picks and exclude parameters are being used before deciding consistent approach - #14244
Draft
CarinaFo wants to merge 1 commit into
Draft
Conversation
CarinaFo
requested review from
agramfort,
drammock,
larsoner and
mscheltienne
as code owners
August 28, 2026 14:18
CarinaFo
marked this pull request as draft
August 28, 2026 14:20
CarinaFo
force-pushed
the
picks_bads_consistent_handling
branch
from
August 29, 2026 15:16
d297e78 to
461ddc5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
second step to fix #13946 and #12197
TBD: default for exclude and for relationship between picks and exclude (if any) as this will require a deprecation cycle and is not consistent at the moment.