Skip to content

atomicwrite: update github.com/moby/sys/sequential v0.7.0 - #243

Draft
thaJeztah wants to merge 1 commit into
moby:mainfrom
thaJeztah:atomicwriter_update_sequential
Draft

atomicwrite: update github.com/moby/sys/sequential v0.7.0#243
thaJeztah wants to merge 1 commit into
moby:mainfrom
thaJeztah:atomicwriter_update_sequential

Conversation

@thaJeztah

Copy link
Copy Markdown
Member
  • update minimum go version to 1.24
  • use os.OpenFile with O_FILE_FLAG_SEQUENTIAL_SCAN on Go 1.26+

Copilot AI lite review requested due to automatic review settings August 5, 2026 07:47

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the atomicwriter Go module to align with a newer minimum Go version and to consume the latest github.com/moby/sys/sequential dependency version, along with its transitive golang.org/x/sys update.

Changes:

  • Bump atomicwriter’s go.mod Go version from 1.18 to 1.24 (but currently uses an invalid patch-form directive).
  • Update github.com/moby/sys/sequential dependency from v0.6.0 to v0.7.0.
  • Update indirect golang.org/x/sys dependency from v0.1.0 to v0.37.0 and refresh go.sum.

Reviewed changes

Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.

File Description
atomicwriter/go.mod Updates module Go version and dependency versions for sequential and x/sys.
atomicwriter/go.sum Refreshes checksums for the updated dependencies.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread atomicwriter/go.mod

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 2 changed files in this pull request and generated no new comments.

@kolyshkin
kolyshkin force-pushed the atomicwriter_update_sequential branch from 7d32b61 to 7b88862 Compare August 28, 2026 04:52
@kolyshkin

Copy link
Copy Markdown
Collaborator

CI is being fixed by #250

- update minimum go version to 1.24
- use os.OpenFile with O_FILE_FLAG_SEQUENTIAL_SCAN on Go 1.26+

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah
thaJeztah force-pushed the atomicwriter_update_sequential branch from 7b88862 to bed1104 Compare August 28, 2026 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants