fix(ios): Zip Slip + skip symlinks on full extract (9.4.1) - #376
Open
plrthink wants to merge 1 commit into
Open
Conversation
Replace SSZipArchive full-unzip with the same minizip path used for selective extract. Rejects traversal entries with ERR_UNSAFE_PATH and skips symlink/__MACOSX entries instead of materializing them. Co-authored-by: Perry <plrthink@gmail.com>
plrthink
marked this pull request as ready for review
August 29, 2026 11:01
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes the remaining iOS security gaps called out in
SECURITY.md:unzip,unzipWithPassword,unzipAssets) no longer delegates toSSZipArchive unzipFileAtPath. It now uses the same minizip extract path as selective extract.ERR_UNSAFE_PATHviaisSafeExtractPath.shouldSkipZipEntry.Changes
extractZipArchivereplaces separate full-unzip (SSZipArchive) and selective-unzip paths.RNZipCancelDelegate(cancel is handled in the minizip loop).SECURITY.md,CHANGELOG.md, and metadata tests.Testing
npm test— 49/49 passing