Add prior discovery client connections#1697
Open
halter73 wants to merge 1 commit into
Open
Conversation
Adds an opt-in PriorDiscoverResult client option for trusted modern discovery snapshots, exposes McpClient.GetDiscoverResult(), and reuses the discovery adoption path so clients can skip server/discover when reconnecting with prior knowledge. Adds tests for zero-probe prior discovery, pinned-version validation, invalid legacy combinations, reusable snapshots, and 2026-07-28 per-request metadata emission. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
McpClientOptions.PriorDiscoverResultso trusted modern discovery snapshots can skip theserver/discoverprobe.McpClient.GetDiscoverResult()for reusable discovery snapshots, including cache hints.Closes #1696
Validation
dotnet builddotnet test .\tests\ModelContextProtocol.Tests\ModelContextProtocol.Tests.csproj --filter "FullyQualifiedName~July2026ProtocolConnectionTests|FullyQualifiedName~July2026ProtocolListMetaEmissionTests"dotnet test --filter "FullyQualifiedName!~DockerEverythingServerTests&FullyQualifiedName!~ServerConformanceTests"Full
dotnet testwas also run. It hit pre-existing/environmental failures: Windows PATH resolution forTestServer.exeunless artifact folders are added to PATH,DockerEverythingServerTests.Sampling_Sse_EverythingServerfailing against the external everything server withUnknown tool: trigger-sampling-request, one timing-sensitiveCancelTaskAsync_ForWorkingTask_Succeedsthat passed on rerun, and net9 conformance fixture startup timeout. The non-external suite passed after adding the generated test-server artifact folders to PATH.