test(web): cover standalone response entry in HistoryEntry status tests#1541
Open
isaka1022 wants to merge 1 commit into
Open
test(web): cover standalone response entry in HistoryEntry status tests#1541isaka1022 wants to merge 1 commit into
isaka1022 wants to merge 1 commit into
Conversation
Acceptance criterion modelcontextprotocol#3 of modelcontextprotocol#1439 ("a standalone response entry isn't shown as Pending") was not tested. Add a `standaloneResponseEntry` fixture with `direction: "response"` and assert that no Pending/OK/Error badge appears, consistent with the existing extractStatus fix that scopes the request lifecycle to `direction === "request"` only.
isaka1022
force-pushed
the
fix/notification-pending-badge
branch
from
3c8d704 to
d509ad5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the missing test for acceptance criterion #3 of #1439 — "a standalone
direction: "response"entry must not show a request-style status badge (most importantly, notPending)."extractStatusfix (return"none"whendirection !== "request") already landed inv2/mainvia History: make Pin and Replay work on HistoryEntry items #1438.responseentry — i.e. the client's reply to a server→client request such asroots/listorsampling— were missing. This PR adds them.This is a test-only change (no behavior change) that guards against a regression of the badge logic.
Test plan
pnpm --filter @modelcontextprotocol/inspector-web test— all green, including the newrenders no request-style status badge for a standalone response entry.Closes #1439