[Schema] Support PHPStan/Psalm integer range types - #422
Merged
chr-hertel merged 1 commit intoAug 16, 2026
Merged
Conversation
wWzZb
marked this pull request as ready for review
August 15, 2026 05:43
wWzZb
requested review from
CodeWithKyrian,
Nyholm,
chr-hertel and
soyuka
as code owners
August 15, 2026 05:43
Contributor
There was a problem hiding this comment.
Pull request overview
Adds PHPStan/Psalm integer-range support to schema generation while leaving bounds under explicit #[Schema] control.
Changes:
- Maps
int<...>PHPDoc types to JSON Schemainteger. - Adds numeric,
min, andmaxbound regression coverage. - Verifies explicit schema constraints remain intact.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/Capability/Discovery/SchemaGenerator.php |
Recognizes integer-range PHPDoc types. |
tests/Unit/Capability/Discovery/SchemaGeneratorFixture.php |
Adds integer-range fixtures. |
tests/Unit/Capability/Discovery/SchemaGeneratorTest.php |
Tests range mapping and explicit minimum handling. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
int<...>PHPDoc ranges as the base JSON Schemaintegertype.minimumandmaximumunder explicit#[Schema]control rather than deriving them from PHPDoc.min, andmaxinterval bounds.The generator gives a non-generic PHPDoc type precedence over the native
inttype. Sinceint<...>was not recognized by the mapper, it fell through to theobjectfallback.Fixes #397
Test plan
vendor/bin/phpunit(1,254 tests, 3,502 assertions, 7 skipped)vendor/bin/phpstan analyse --memory-limit=-1vendor/bin/php-cs-fixer fix --dry-runcomposer validate --strictphpdocumentor/reflection-docblock5.6.0