fix: include PROGRAMDATA in inherited Windows environment - #3334
fix: include PROGRAMDATA in inherited Windows environment#3334AbarnaaSree wants to merge 1 commit into
Conversation
|
Thanks for the contribution. This repository only keeps pull requests open when they're linked to an issue that a maintainer has assigned to the author — CONTRIBUTING.md explains why and how we work. This PR has been closed for now because its description doesn't yet link an open issue in this repository (with If there isn't an issue for this yet, please open one — a clear description of the problem is genuinely the most useful thing for us. Then add There's no need to open a new PR — this one will be reopened. While it's closed, please push any updates as new commits rather than force-pushing, since GitHub can't reopen a PR whose branch has been rewritten. Maintainers: reopening this PR, removing the |
Description
Fixes a Windows-specific MCP SSH transport issue where the subprocess can terminate shortly after the
initializemessage.On Windows, the stdio client builds a restricted inherited environment for spawned MCP server processes.
PROGRAMDATAwas missing from the inherited environment variables.This can cause Windows executables such as
ssh.exeand related process behavior to differ from a normal environment.Change
Added
PROGRAMDATAtoDEFAULT_INHERITED_ENV_VARSinsrc/mcp/client/stdio.py.Testing
Popen.PROGRAMDATAis now included.git diff --checkpasses.Related Issue
Fixes/addresses MCP SSH transport closing immediately on Windows after the
initializemessage.Issue: #1822