fix: harden signing key handling - #1166
Open
DaleSeo wants to merge 1 commit into
Open
Conversation
github-actions
Bot
added
T-dependencies
DaleSeo
force-pushed
the
fix/1161-signing-key-hardening
branch
from
August 11, 2026 23:42
619a0e8 to
1dfe003
Compare
DaleSeo
marked this pull request as ready for review
August 11, 2026 23:55
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1161.
Motivation and Context
RequestStateCodecpreviously accepted keys of any length despite documenting a 32-byte recommendation.This adds a validated
try_newconstructor while preserving the existing new API, and zeroizes storedrequest-state keys on drop. Client secrets and private-key JWT signing keys are also redacted from Debug
output.
How Has This Been Tested?
Added tests
Breaking Changes
None.
Types of changes
Checklist