Repository navigation
Conversation
DaleSeo
approved these changes
Oct 9, 2026
DaleSeo
left a comment
Member
There was a problem hiding this comment.
Thanks for the following up, @ragen1337! I left a couple of minor comments.
Comment on lines
+76
to
+79
| cargo clippy --package rmcp --lib -- -D warnings | ||
| cargo clippy --package rmcp --lib --no-default-features -- -D warnings | ||
| cargo clippy --package rmcp --lib --no-default-features --features client -- -D warnings | ||
| cargo clippy --package rmcp --lib --no-default-features --features server -- -D warnings |
Member
There was a problem hiding this comment.
Can we keep the guarantee from regressing as new features are added?
Suggested change
| cargo clippy --package rmcp --lib -- -D warnings | |
| cargo clippy --package rmcp --lib --no-default-features -- -D warnings | |
| cargo clippy --package rmcp --lib --no-default-features --features client -- -D warnings | |
| cargo clippy --package rmcp --lib --no-default-features --features server -- -D warnings | |
| cargo hack clippy --package rmcp --lib --each-feature --exclude-features local -- -D warnings |
| #[cfg(feature = "transport-streamable-http-client")] | ||
| #[cfg(all( | ||
| feature = "transport-streamable-http-client", | ||
| any(feature = "client", feature = "server") |
Member
There was a problem hiding this comment.
I think this would describe the dependency more accurately.
Suggested change
| any(feature = "client", feature = "server") | |
| feature = "client" |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to my comment in #1314.
Some crate-internal helpers are only called from client or server code, so building rmcp with fewer features fails under
-D warnings:Default, client-only and server-only builds fail the same way on other helpers. I gated them with
#[cfg], likesend_subscription_request.ErrorData::transport_closedis only used by the streamable HTTP client, so it now also needsclientorserver.CI didn't see it because both clippy steps enable
clientandserver, and the no-default-features test job from #1318 doesn't use-D warnings. @chrikrah suggested a clippy step for this in #1314, so I added one. It's--libonly because some tests don't build with reduced features.With
-D warnings, no features and every single feature fail on main and pass here. Clippy and fmt pass.cargo test --all-featureshas the same 2child_processfailures as main for me. No API changes.