fix(everything): clean up subscriptions on session disconnect - #4712
Open
arimu1 wants to merge 1 commit into
Open
fix(everything): clean up subscriptions on session disconnect#4712arimu1 wants to merge 1 commit into
arimu1 wants to merge 1 commit into
Conversation
Export removeSubscriber() to drop a session from all URI subscriber sets when a transport session closes, and call it from cleanup() alongside the existing interval and logging teardown. Fixes modelcontextprotocol#4710
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
removeSubscriber(sessionId)insrc/everything/resources/subscriptions.tsto remove a disconnected session from every URI subscriber set and drop empty map entries.removeSubscriber(sessionId)from the server factorycleanup()alongside the existing logging, resource-update interval, and task-store teardown.Fixes #4710
Test plan
npx vitest run __tests__/resources.test.ts __tests__/server.test.ts— 31/31 passingnpm run build— clean TypeScript compile