Repository navigation
fix(client): use public cache after private expiry - #3218
Open
1828703450qqcom-ux wants to merge 1 commit into
Open
1828703450qqcom-ux wants to merge 1 commit into
1828703450qqcom-ux wants to merge 1 commit into
Conversation
🦋 Changeset detectedLatest commit: 25e0f02 The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@modelcontextprotocol/client
@modelcontextprotocol/codemod
@modelcontextprotocol/core
@modelcontextprotocol/server
@modelcontextprotocol/server-legacy
@modelcontextprotocol/express
@modelcontextprotocol/fastify
@modelcontextprotocol/hono
@modelcontextprotocol/node
commit: |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When clients share a response cache but use different
cachePartitionvalues, one client can retain an expired private entry after another client stores a public replacement._probe()currently returns the private entry before considering its TTL.read()then rejects that entry as stale without looking at the fresh public entry, causing an unnecessary request; tool descriptors and output validators also keep using the old private list.Prefer the private entry while it is fresh, then use a held public entry. If the shared slot is absent or not public, retain the private entry for derived metadata as before.
read()still enforces TTL, while descriptors and validators retain the selected public list when it later expires. The single-partition case still performs one store lookup.This is a small bug fix under the contribution guide's exception for straightforward fixes with regression tests. No API or protocol change.
Validation
listTools()returns the private server's['a']through a second request rather than serving the public cached['b'].git diff --checkpass.pnpm run typecheck:all,pnpm run lint:all, andpnpm run build:all.On Windows, the initial cold full-client run hit the existing
ensureBuiltharness problem (spawn pnpm ENOENT; see #3177). I explicitly rancorepack pnpm --filter @modelcontextprotocol/core buildandcorepack pnpm --filter @modelcontextprotocol/client build, then reran the full client suite successfully. The harness is unchanged in this PR.Prepared and checked with Codex agents. The test execution and source review described here were automated; no human-review attestation is implied.