Repository navigation
ci: remove owner approval gate from npm publish workflow - #118
Merged
Merged
Conversation
The publish job no longer references the npm-release GitHub Environment, so npm publishing runs without a required-reviewer approval step. Publishing remains protected by the NPM_RELEASE_ENABLED kill switch, npm Trusted Publisher settings, and the publish.ts environment guard. - remove environment: npm-release from the publish job - guard test now asserts no environment reference in release.yml - update release docs (en/zh-CN) to drop approval instructions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The publish job no longer references the npm-release GitHub Environment, so npm publishing runs without a required-reviewer approval step. Publishing remains protected by the NPM_RELEASE_ENABLED kill switch, npm Trusted Publisher settings, and the publish.ts environment guard.
Summary
Why
Type
Surface area
Checklist
bun run verify:fullpassesBehavior / risk
Validation