Repository navigation
fix(theme): restore GitHub Dark Default as the default theme - #1195
Open
benvinegar wants to merge 3 commits into
Open
benvinegar wants to merge 3 commits into
benvinegar wants to merge 3 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
[Medium impact] The PR appears safe to merge. SummaryRestores
Reviews (1) · Last reviewed commit: "fix(theme): restore GitHub Dark Default ..." · Reviewed by Greptile |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Restore
github-dark-defaultas Hunk's default theme, verified against the parent of 6c95708 (#1128), which switched the default toterminal.terminalopt-in, including its live palette updates; keep explicitautoselection unchanged.This belongs in core because it changes the built-in launch default, not an optional workflow. No themes are removed.
Validation
All CI checks pass at 6013ad5, including Linux validation/packaging, PTY integration, Windows compatibility, macOS/Windows compiled portability, website, and Nix packaging. Local checks ran on Linux; macOS and Windows were not tested locally.
bun run typecheckbun run test(both shards)bun run test:integration(265 passed, 1 platform skip)bun run test:tty-smoke(11 real-TTY tests)bun run check:packbun run generate:docsbun test test/pty/comment-target.test.ts test/pty/open-scroll-integration.test.tsfive consecutive timesNo before/after media is attached; visual verification is limited to the real-TTY/PTY tests.
This PR description was generated by Pi using GPT-6.1-sol