feat(dis_properties): add grid method to get discretization properties - #2795
Open
jlarsen-usgs wants to merge 5 commits into
Open
feat(dis_properties): add grid method to get discretization properties#2795jlarsen-usgs wants to merge 5 commits into
jlarsen-usgs wants to merge 5 commits into
Conversation
* replace numpy .shape = with .reshape() in Raster * replace .utcfromtimestamp with fromtimestamp(timestamp, timezone.utc) in ModelTime
* numpy will be deprecating `.shape =` reshaping, migrating to reshape convention to prevent DeprecationWarnings
* returns dictionary of keyword arguments to build DIS, DISV, and DISU depending on grid type * added cell `.area` calculation via shoelace algorithm to `Grid` * remove deprecated flopy.mf6.utils/reference.py which housed "pre-modelgrid" spatial reference support for MF6 models
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #2795 +/- ##
===========================================
+ Coverage 55.5% 73.2% +17.7%
===========================================
Files 644 660 +16
Lines 124135 132182 +8047
===========================================
+ Hits 68947 96886 +27939
+ Misses 55188 35296 -19892
🚀 New features to boost your workflow:
|
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
.areacalculation via shoelace algorithm toGridMirrors support outlined in removed PR #2700