fix(autotest): skip tests that need an optional dependency - #2797
Open
jdhughes-dev wants to merge 1 commit into
Open
fix(autotest): skip tests that need an optional dependency#2797jdhughes-dev wants to merge 1 commit into
jdhughes-dev wants to merge 1 commit into
Conversation
The nightly optional dependency job runs the test suite with only the required dependencies installed. Tests that build a DISV or DISU grid, an hfb array, or a Delaunay triangulation failed there with an ImportError for shapely or scipy rather than being skipped, and a module level import of pyshp or scipy stopped test_export, test_grid, and test_shapefile_utils from being collected at all. Those tests are now marked with the package they need and the module level imports have been moved into the tests that use them. The parameter list for test_voronoi_grid was emptied when shapely or scipy was missing while its list of ids was not, which is a collection error; the test is skipped by its requires_pkg mark, so the guard has been removed.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #2797 +/- ##
===========================================
+ Coverage 55.5% 72.8% +17.2%
===========================================
Files 644 662 +18
Lines 124135 133012 +8877
===========================================
+ Hits 68947 96847 +27900
+ Misses 55188 36165 -19023 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tests that build a DISV or DISU grid, an hfb array, or a Delaunay triangulation failed in the nightly optional dependency job with an
ImportErrorfor shapely or scipy rather than being skipped, and a module level import of pyshp or scipy stoppedtest_export,test_grid, andtest_shapefile_utilsfrom being collected. Those tests are now marked with the package they need and the module level imports have been moved into the tests that use them.The parameter list for
test_voronoi_gridwas emptied when shapely or scipy was missing while its list of ids was not, which is a collection error; the test is skipped by itsrequires_pkgmark, so the guard has been removed.