Translate configuration form labels with manager lexicons - #221
Open
infinityscroll wants to merge 1 commit into
Open
Translate configuration form labels with manager lexicons#221infinityscroll wants to merge 1 commit into
infinityscroll wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does it do ?
Adds opt-in
%keyand simple[[%key]]references for setting/group labels and descriptions, selectbox display labels, and required-field error labels. Additional topics can be configured withclientconfig.lexicon_topics.Translations use the manager user's resolved language. The home controller translates copies of the configuration records and sends separate option value/label rows to the form. Stored values, defaults, raw references, and admin editing/import/export data stay unchanged.
Includes setup documentation and standalone PHP/JavaScript regression checks. Existing dynamic option processing remains available; the documentation explains using
%keywhen that processing is enabled.Why is it needed ?
Multilingual editors currently see literal lexicon references in the configuration form. This lets each editor read the labels in their manager language while editing the same underlying settings, including in context-aware mode.
Validation:
%website.group) and passes with this change.git diff --checkpasses.A full MODX 2/3 browser installation test has not been run.
tests/README.mdincludes that integration checklist.Related issue(s)/PR(s)
Fixes #201.