Skip to content

refactor(forks): rename MONAD_NEXT to MONAD_TEN, add no-op MONAD_NEXT - #39

Merged
pdobacz merged 3 commits into
forks/monad_ninefrom
mip-8-monad-ten
Jul 27, 2026
Merged

refactor(forks): rename MONAD_NEXT to MONAD_TEN, add no-op MONAD_NEXT#39
pdobacz merged 3 commits into
forks/monad_ninefrom
mip-8-monad-ten

Conversation

@pdobacz

@pdobacz pdobacz commented Jul 27, 2026

Copy link
Copy Markdown
Collaborator

DRAFT, because this should be merged only after category-labs/monad actually gates MIP-8 on MONAD_TEN

🗒️ Description

Renames the MIP-8 fork MONAD_NEXT to MONAD_TEN, and adds a fresh no-op
MONAD_NEXT after it as the landing spot for the next MIPs.

Not included, deliberately:

  • No MONAD_TENToMONAD_NEXTAtTime15k transition fork — no test targets it, and
    a transition across a no-op boundary asserts nothing.
  • No FORK_REVISION_SCHEDULES entry in the monad runloop consumer — there is no
    monad revision for MONAD_NEXT yet. Consuming a MONAD_NEXT fixture fails
    with no monad revision schedule for network MONAD_NEXT until one exists. CI
    fills --until=MONAD_TEN, so no such fixture is produced today.

Generated JSON fixtures do not differ except fork name and source hash in metadata

Greptile Summary

This PR renames the MIP-8 fork to MONAD_TEN and introduces MONAD_NEXT as its no-op successor.

  • Copies the former MONAD_NEXT specification into the new MONAD_TEN package and updates fork references and MIP-8 tests.
  • Adds MONAD_TEN and MONAD_NEXT ordering, transition definitions, and consumer revision schedules.
  • Restricts configured CI fixture generation to MONAD_TEN and updates documentation.

Confidence Score: 3/5

This PR should not merge until the unsupported MONAD_NEXT revision schedule and discoverable no-op transition are removed or the Monad runloop supports revision 11.

Selecting MONAD_NEXT generates and consumes fixtures that are routed to revision 11 even though MONAD_NEXT is only a behaviorally identical placeholder and no corresponding runloop revision exists.

Files Needing Attention: packages/testing/src/execution_testing/client_clis/clis/monad.py; packages/testing/src/execution_testing/forks/forks/transition.py

Important Files Changed

Filename Overview
packages/testing/src/execution_testing/client_clis/clis/monad.py Renames revision 10 to MONAD_TEN but prematurely maps the placeholder MONAD_NEXT and its transition to unsupported revision 11.
packages/testing/src/execution_testing/forks/forks/transition.py Renames the MIP-8 transition and adds a discoverable no-op MONAD_TEN-to-MONAD_NEXT transition.
packages/testing/src/execution_testing/forks/forks/forks.py Moves MIP-8 behavior to MONAD_TEN and defines MONAD_NEXT as an identical subclass.
src/ethereum/forks/monad_ten/fork.py Adds the renamed MONAD_TEN specification implementation copied from the former MONAD_NEXT fork.
.github/configs/feature.yaml Stops normal and runloop CI fixture generation at MONAD_TEN, avoiding placeholder MONAD_NEXT fixtures in current CI.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart LR
  N9[MONAD_NINE] -->|MIP-8 at 15k| T[MONAD_TEN / revision 10]
  T -->|exported no-op transition at 15k| N[MONAD_NEXT / configured revision 11]
  N --> C[Monad fixture consumer]
  C --> R[eest-runner receives unsupported revision 11]
Loading

Fix All in Claude Code

Prompt To Fix All With AI
Fix the following 1 code review issue. Work through them one at a time, proposing concise fixes.

---

### Issue 1 of 1
packages/testing/src/execution_testing/client_clis/clis/monad.py:39-42
**Unsupported revision 11 schedule**

When MONAD_NEXT or its exported transition is selected, these schedules send revision 11 to `eest-runner` even though MONAD_NEXT is only a no-op placeholder with no corresponding Monad revision, causing unsupported fixture execution instead of the documented `no monad revision schedule` rejection.

Reviews (1): Last reviewed commit: "update README fork range to MONAD_TEN" | Re-trigger Greptile

Greptile also left 1 inline comment on this PR.

pdobacz added 2 commits July 27, 2026 11:14
MIP-8 now lands in MONAD_TEN; generated fixture content is unchanged.

Co-Authored-By: Claude <claude-opus-5>
Generated with `ethereum-spec-new-fork`; a landing spot for the next MIPs.

Co-Authored-By: Claude <claude-opus-5>
Also repoints the new-fork tool link at the section it actually lives in.

Co-Authored-By: Claude <claude-opus-5>
@pdobacz
pdobacz marked this pull request as ready for review July 27, 2026 15:50
@pdobacz
pdobacz requested review from QEDK and mijovic as code owners July 27, 2026 15:50
Comment thread packages/testing/src/execution_testing/client_clis/clis/monad.py

@QEDK QEDK left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@pdobacz
pdobacz merged commit e022416 into forks/monad_nine Jul 27, 2026
13 checks passed
@pdobacz
pdobacz deleted the mip-8-monad-ten branch July 27, 2026 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants