Skip to content

fix(tests): EIP-7981 balance boundary under Monad's inclusion rule - #69

Merged
pdobacz merged 2 commits into
forks/monad_ninefrom
fix/eip7981-value-above-balance
Oct 23, 2026
Merged

pdobacz merged 2 commits into
forks/monad_ninefrom
fix/eip7981-value-above-balance

Conversation

@pdobacz

@pdobacz pdobacz commented Oct 20, 2026 •

Copy link
Copy Markdown
Collaborator

#67 broke the EIP-7981 test in a way I didn't expect. Fixing here by excluding some original 7981 coverage and recreating in tests/monad_eleven

RetriggerView in GreptileConfidence Score: 5/5

The PR appears safe to merge.

Summary

Adjusts EIP-7981 tests for Monad’s fee-only inclusion rule.

  • EIP-7981 balance tests now match Monad's fee-only inclusion rule.

Reviews (1) · Last reviewed commit: "test(monad_eleven): EIP-7981 surcharged ..." · Reviewed by Greptile

Monad includes a transaction whose sender covers the gas fees but not the value.

Co-Authored-By: Claude <claude-fable-5-1>
The fee-pricing helper moves to the reserve balance helpers so both suites share it.

Co-Authored-By: Claude <claude-fable-5-1>
@pdobacz
pdobacz requested review from QEDK and mijovic as code owners October 20, 2026 13:32
@pdobacz

pdobacz commented Oct 20, 2026

Copy link
Copy Markdown
Collaborator Author

https://github.com/monad-developers/execution-specs/actions/runs/39431547666 Tells us the release will succeed.

@QEDK QEDK left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@pdobacz
pdobacz merged commit 304cc34 into forks/monad_nine Oct 23, 2026
8 checks passed
@pdobacz
pdobacz deleted the fix/eip7981-value-above-balance branch October 23, 2026 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants