Repository navigation
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The existing test never invokes setupShard, leaving no regression coverage that StartLog receives only the new IDs under log_server_ids for both supported response spellings.
1 open issue
What changed in this PR
Updates mongodb-runner’s SLS log setup to use the IDs required by recent SLS versions, avoiding scheduler rejection caused by sending legacy server entries.
Changes:
- Reads
log_server_idsorlogServerIdsfrom GetLogServers. - Sends those values as
log_server_idsin StartLog, retaining the empty-list check.
| File | Description |
|---|---|
packages/mongodb-runner/src/sls.ts |
Corrects the GetLogServers-to-StartLog ID mapping. |
Review effort: Balanced
…r call
GetLogServers still returns the legacy server_ids list ({uri, cell} objects) alongside
log_server_ids, and StartLog now requires the log_server_ids values. Sending the legacy list makes
the scheduler reject the request with a misleading "store_id mismatch" error.
Read log_server_ids / logServerIds from the GetLogServers response and send them as log_server_ids,
matching the server's SLS fixture:(start_log() in buildscripts/modules/atlas/fixtures/sls.py). No
fallback to the legacy field: mixing the two shapes would send the wrong payload against older
stacks.
autarch
force-pushed
the
11-17-fix_mongodb-runner_send_log_server_ids_to_the_sls_startlog_scheduler_call
branch
from
November 17, 2026 18:33
86e0e55 to
6f8c686
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
GetLogServers still returns the legacy server_ids list ({uri, cell} objects) alongside log_server_ids, and StartLog now requires the log_server_ids values. Sending the legacy list makes the scheduler reject the request with a misleading "store_id mismatch" error.
We now read log_server_ids / logServerIds from the GetLogServers response and send them as log_server_ids, matching the server's SLS fixture:(start_log() in buildscripts/modules/atlas/fixtures/sls.py).
This is needed in order to start the most recent versions of SLS.
Open Questions
None
Checklist