Skip to content

fix(mongodb-runner): send log_server_ids to the SLS StartLog scheduler call - #973

Open
autarch wants to merge 1 commit into
mainfrom
11-17-fix_mongodb-runner_send_log_server_ids_to_the_sls_startlog_scheduler_call
Open

autarch wants to merge 1 commit into
mainfrom
11-17-fix_mongodb-runner_send_log_server_ids_to_the_sls_startlog_scheduler_call

Conversation

@autarch

@autarch autarch commented Nov 17, 2026

Copy link
Copy Markdown
Collaborator

Description

GetLogServers still returns the legacy server_ids list ({uri, cell} objects) alongside log_server_ids, and StartLog now requires the log_server_ids values. Sending the legacy list makes the scheduler reject the request with a misleading "store_id mismatch" error.

We now read log_server_ids / logServerIds from the GetLogServers response and send them as log_server_ids, matching the server's SLS fixture:(start_log() in buildscripts/modules/atlas/fixtures/sls.py).

This is needed in order to start the most recent versions of SLS.

Open Questions

None

Checklist

Copilot AI balanced review requested due to automatic review settings November 17, 2026 17:45

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The existing test never invokes setupShard, leaving no regression coverage that StartLog receives only the new IDs under log_server_ids for both supported response spellings.

1 open issue
What changed in this PR

Updates mongodb-runner’s SLS log setup to use the IDs required by recent SLS versions, avoiding scheduler rejection caused by sending legacy server entries.

Changes:

  • Reads log_server_ids or logServerIds from GetLogServers.
  • Sends those values as log_server_ids in StartLog, retaining the empty-list check.
File Description
packages/​mongodb-runner/​src/​sls.ts Corrects the GetLogServers-to-StartLog ID mapping.

Review effort: Balanced

Comment thread packages/mongodb-runner/src/sls.ts Resolved
…r call

GetLogServers still returns the legacy server_ids list ({uri, cell} objects) alongside
log_server_ids, and StartLog now requires the log_server_ids values. Sending the legacy list makes
the scheduler reject the request with a misleading "store_id mismatch" error.

Read log_server_ids / logServerIds from the GetLogServers response and send them as log_server_ids,
matching the server's SLS fixture:(start_log() in buildscripts/modules/atlas/fixtures/sls.py). No
fallback to the legacy field: mixing the two shapes would send the wrong payload against older
stacks.
@autarch
autarch force-pushed the 11-17-fix_mongodb-runner_send_log_server_ids_to_the_sls_startlog_scheduler_call branch from 86e0e55 to 6f8c686 Compare November 17, 2026 18:33
@autarch
autarch requested a balanced review from Copilot November 17, 2026 18:33

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues block the log-server ID update.

No open issues 🎉

1 resolved since last review

Review effort: Balanced

@autarch
autarch marked this pull request as ready for review November 17, 2026 18:35
@autarch
autarch requested review from a team as code owners November 17, 2026 18:35
@autarch
autarch requested a review from Anemy November 17, 2026 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants