PYTHON-6049 - Allow the full range of possible errors for a CSOT timeout - #3005
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the transactions CSOT regression test to assert timeout semantics (via the exception’s timeout attribute) instead of asserting a single concrete exception type, matching the approach used by the unified CSOT tests and reducing flakiness.
Changes:
- Broaden the expected exception in
test_callback_not_retried_after_csot_timeoutfromExecutionTimeouttoPyMongoError. - Assert
ctx.exception.timeoutto validate that the failure was caused by a timeout, regardless of the specific error subclass.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| test/test_transactions.py | Updates the synchronous transactions CSOT test to assert exception.timeout instead of requiring ExecutionTimeout. |
| test/asynchronous/test_transactions.py | Mirrors the same CSOT assertion change for the asynchronous transactions CSOT test. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
sleepyStick
approved these changes
Aug 25, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Contributor
Author
|
Failures are unrelated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PYTHON-6049
Changes in this PR
The
test_callback_not_retried_after_csot_timeouttest explicitly checks that the raised error is anExecutionTimeoutto assert that the CSOT timeout has expired. This is inconsistent with how the unified tests assert the same behavior, which is by checking thetimeoutattribute on the error itself. Since a CSOT timeout expiring during an operation can raise multiple kinds of errors depending on the exact time and place it occurs, this causes the test to be flaky.This PR aligns the test with how the unified tests assert for CSOT timeout expiration.
Test Plan
Test changes.
Checklist
Checklist for Author
[ ] Did you update the changelog (if necessary)?[ ] Is any followup work tracked in a JIRA ticket? If so, add link(s).Checklist for Reviewer