PYTHON-6014 Move internal pool classes into pool_shared.py - #3020
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors PyMongo’s connection pool implementation by relocating a few shared internal pool helpers (generation/state tracking and closed-pool error) into pymongo/pool_shared.py, and updates imports across synchronous/asynchronous pool code and the related test utilities.
Changes:
- Moved
_PoolClosedError,_PoolGeneration, andPoolStatedefinitions intopymongo/pool_shared.py. - Updated
pymongo.synchronous.poolandpymongo.asynchronous.poolto import those shared helpers frompool_shared. - Updated tests/utilities to import the moved helpers from
pymongo.pool_sharedinstead of the per-implementation pool modules.
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
pymongo/pool_shared.py |
Adds shared internal pool classes (_PoolClosedError, _PoolGeneration, PoolState) so both pool implementations can reuse them. |
pymongo/synchronous/pool.py |
Removes local definitions and imports the shared pool helpers from pool_shared. |
pymongo/asynchronous/pool.py |
Removes local definitions and imports the shared pool helpers from pool_shared. |
test/utils.py |
Switches sync test utilities to import _CancellationContext / _PoolGeneration from pool_shared. |
test/utils_shared.py |
Switches shared test utilities to import _CancellationContext / _PoolGeneration from pool_shared. |
test/test_transactions.py |
Updates sync transactions tests to import PoolState from pool_shared. |
test/test_connection_monitoring.py |
Updates sync CMAP tests to import PoolState / _PoolClosedError from pool_shared. |
test/asynchronous/utils.py |
Switches async test utilities to import _CancellationContext / _PoolGeneration from pool_shared. |
test/asynchronous/test_transactions.py |
Updates async transactions tests to import PoolState from pool_shared. |
test/asynchronous/test_connection_monitoring.py |
Updates async CMAP tests to import PoolState / _PoolClosedError from pool_shared. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PYTHON-6014
Changes in this PR
See ticket.
Test Plan
Existing test suite.
Checklist
Checklist for Author
[ ] Did you update the changelog (if necessary)?[ ] Is there test coverage?[ ] Is any followup work tracked in a JIRA ticket? If so, add link(s).Checklist for Reviewer