PYTHON-6019 Consolidate mongo_client module-level helpers into shared… - #3031
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Refactors MongoClient module-level helper logic by extracting common internals into a new shared module so the synchronous and asynchronous clients can reuse identical implementations.
Changes:
- Introduces
pymongo/mongo_client_shared.pyto host shared internal helpers (_add_retryable_write_error,_after_fork_child,_detect_external_db). - Updates both
pymongo/asynchronous/mongo_client.pyandpymongo/synchronous/mongo_client.pyto import and use the shared helpers instead of local duplicates. - Adjusts
register_at_forkwiring to call the shared_after_fork_childwith the appropriate client registry.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| pymongo/synchronous/mongo_client.py | Removes duplicated helper implementations and uses shared helpers; updates register_at_fork callback wiring. |
| pymongo/asynchronous/mongo_client.py | Removes duplicated helper implementations and uses shared helpers; updates register_at_fork callback wiring. |
| pymongo/mongo_client_shared.py | New internal module containing shared MongoClient helpers used by both sync/async implementations. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
sleepyStick
approved these changes
Sep 1, 2026
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… file
PYTHON-6019
Changes in this PR
See ticket.
Test Plan
Existing test suite.
Checklist
Checklist for Author
[ ] Did you update the changelog (if necessary)?[ ] Is any followup work tracked in a JIRA ticket? If so, add link(s).Checklist for Reviewer