Skip to content

PYTHON-6021 Move _write_concern_for_cmd into BaseObject #3036

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sleepyStick merged 2 commits into from
Sep 4, 2026
Merged

PYTHON-6021 Move _write_concern_for_cmd into BaseObject #3036

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d5943ae
PYTHON-6021 Move _write_concern_for_cmd into BaseObject
sleepyStick Sep 2, 2026
dfebd2a
Merge branch 'main' into PYTHON-6021
sleepyStick Sep 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 0 additions & 9 deletions pymongo/asynchronous/collection.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -390,15 +390,6 @@ def with_options(
read_concern or self.read_concern,
)

def _write_concern_for_cmd(
self, cmd: Mapping[str, Any], session: Optional[AsyncClientSession]
) -> WriteConcern:
raw_wc = cmd.get("writeConcern")
if raw_wc is not None:
return WriteConcern(**raw_wc)
else:
return self._write_concern_for(session)

# See PYTHON-3084.
__iter__ = None

Expand Down
9 changes: 9 additions & 0 deletions pymongo/common.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -978,6 +978,15 @@ def _write_concern_for(self, session: Optional[_AgnosticClientSession]) -> Write
return DEFAULT_WRITE_CONCERN
return self.write_concern

def _write_concern_for_cmd(
self, cmd: Mapping[str, Any], session: Optional[_AgnosticClientSession]
) -> WriteConcern:
raw_wc = cmd.get("writeConcern")
Comment on lines +981 to +984
if raw_wc is not None:
return WriteConcern(**raw_wc)
else:
return self._write_concern_for(session)

@property
def read_preference(self) -> _ServerMode:
"""Read only access to the read preference of this instance.
Expand Down
9 changes: 0 additions & 9 deletions pymongo/synchronous/collection.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -392,15 +392,6 @@ def with_options(
read_concern or self.read_concern,
)

def _write_concern_for_cmd(
self, cmd: Mapping[str, Any], session: Optional[ClientSession]
) -> WriteConcern:
raw_wc = cmd.get("writeConcern")
if raw_wc is not None:
return WriteConcern(**raw_wc)
else:
return self._write_concern_for(session)

# See PYTHON-3084.
__iter__ = None

Expand Down
Loading