PYTHON-6004 Scope OIDC test failpoints to the auth_oidc appName - #3044
Merged
Conversation
blink1073
force-pushed
the
PYTHON-6004
branch
from
September 8, 2026 12:54
b96e9e5 to
60c1aba
Compare
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The focused changes correctly scope failpoints and consistently configure matching client metadata.
Pull request overview
Scopes OIDC failpoints to test clients, preventing unrelated connections from consuming one-shot failures.
Changes:
- Moves failpoint
appNamefiltering intodata. - Adds
auth_oidcto single-client URIs across OIDC environments. - Keeps synchronous and asynchronous tests aligned.
File summaries
| File | Description |
|---|---|
.evergreen/scripts/oidc_tester.py |
Configures OIDC app names in test environments. |
test/asynchronous/test_auth_oidc.py |
Scopes asynchronous OIDC failpoints. |
test/test_auth_oidc.py |
Mirrors the asynchronous test change. |
Review details
- Files reviewed: 3/3 changed files
- Comments generated: 0
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
sleepyStick
approved these changes
Sep 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PYTHON-6004
Changes in this PR
The OIDC auth tests used
failCommandwithappNameas a top-levelconfigureFailPointfield, which the server ignores. The failpoint was unscoped, so it could fire on the wrong connection and the reauthentication tests (test_4_1, test_4_2) flaked on Atlas-backed OIDC environments.auth_oidcclient by movingappNameintodata.appName=auth_oidctoMONGODB_URI_SINGLEso test clients advertise that name in every environment, including k8s.Test Plan
Ran the OIDC tasks on Evergreen. Passing build, executed twice. ### TODO
Checklist
Checklist for Author
Checklist for Reviewer