test(NODE-7656): Skip time-sensitive CSOT tests opening change streams on 9.0+ sharded clusters#5002
test(NODE-7656): Skip time-sensitive CSOT tests opening change streams on 9.0+ sharded clusters#5002PavelSafronov wants to merge 1 commit into
Conversation
…s on 9.0+ sharded clusters
There was a problem hiding this comment.
Pull request overview
This PR adjusts the Client-Side Operations Timeout (CSOT) unified spec fixtures to skip specific change stream-opening tests on sharded clusters running MongoDB 9.0+ by tightening runOnRequirements for those test cases.
Changes:
- Added per-test
runOnRequirementsto allow these change stream CSOT tests on replica sets, while restricting sharded execution tomaxServerVersion: 8.99. - Updated both YAML and JSON representations of the affected CSOT spec suites to keep them in sync.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| test/spec/client-side-operations-timeout/retryability-timeoutMS.yml | Adds topology/version gating to skip sharded 9.0+ for retryability change stream CSOT tests |
| test/spec/client-side-operations-timeout/retryability-timeoutMS.json | Mirrors the same runOnRequirements changes in the JSON fixture consumed by the spec runner |
| test/spec/client-side-operations-timeout/override-operation-timeoutMS.yml | Adds topology/version gating to skip sharded 9.0+ for override-timeout change stream CSOT tests |
| test/spec/client-side-operations-timeout/override-operation-timeoutMS.json | Mirrors the same runOnRequirements changes in the JSON fixture consumed by the spec runner |
tadjik1
left a comment
There was a problem hiding this comment.
Thanks @PavelSafronov! Please check the configuration for these tests, we already skip them.
Excellent point. I removed the code skips and found that we need some more tests skipped in our specifications. PR opened to add these: mongodb/specifications#1964 |
Description
Summary of Changes
Skip CSOT tests against 9.0+ server.
Double check the following
npm run check:lint)type(NODE-xxxx)[!]: descriptionfeat(NODE-1234)!: rewriting everything in coffeescript