Skip to content

chore: skip failing SDAM tests - #5010

Merged
PavelSafronov merged 1 commit into
mongodb:mainfrom
seanrmilligan:sean.milligan/skip-tests
Jul 24, 2026
Merged

chore: skip failing SDAM tests#5010
PavelSafronov merged 1 commit into
mongodb:mainfrom
seanrmilligan:sean.milligan/skip-tests

Conversation

@seanrmilligan

@seanrmilligan seanrmilligan commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

Description

Summary of Changes

Skip failing SDAM tests

Double check the following

  • Lint is passing (npm run check:lint)
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@seanrmilligan
seanrmilligan marked this pull request as ready for review July 24, 2026 19:19
@seanrmilligan
seanrmilligan requested a review from a team as a code owner July 24, 2026 19:19
Copilot AI review requested due to automatic review settings July 24, 2026 19:19

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the SDAM unified spec integration test runner to skip three currently failing SDAM unified tests by adding them to the existing skipTable in the SDAM spec test harness.

Changes:

  • Added three new SDAM unified-test description patterns to the integration test skip table.
  • Annotated new skips with a TODO reference (NODE-7703) indicating they should be removed after a server upgrade.

@seanrmilligan
seanrmilligan force-pushed the sean.milligan/skip-tests branch from ba21df4 to 25d44e1 Compare July 24, 2026 19:37
@PavelSafronov PavelSafronov changed the title Skip failing SDAM tests chore: skip failing SDAM tests Jul 24, 2026

@PavelSafronov PavelSafronov left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good.

@PavelSafronov
PavelSafronov merged commit 6bff502 into mongodb:main Jul 24, 2026
31 of 33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants