Repository navigation
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Patch bump; the code change is the one the bump forces —
useStoreis deprecated as of 1.33.1 and the repo typecheck errors on deprecated, so all call sites move to the newuseSelector(identical selector → signal signature).Upstream 1.33.0 → 1.33.5 (diffed the published sources):
useSelectoradded /useStoredeprecated; SSR-safeformIdfallback viacreateUniqueId(); form-core 1.33.5 —isValidatingrace fixed (pending-validations counter), form-levelfieldErrorsnow applied for fields missing fromfieldMeta, re-submission re-validates instead of early-returning (clears staleonBlurerrors),deleteFieldno longer nukes sibling fields on prefix match.Evidence
typescript(no-deprecated): useStore is deprecated. Use form.useSelector insteadacross the modals above.After:
pnpm oxlint --type-aware --type-checkclean;pnpm vitest run— 137 files, 2539 tests, all passing.@tanstack+solid-form@1.33.5from the pnpm store, loaded module exportsuseSelector, forms carrycl-…createUniqueIdform ids):includedrives the live preview re-filtering 133 → 200 → 1 words (theuseSelector((s) => s.values)→ debounce → preview chain); preset "apply" populates fields viasetFieldValue; "set" submit runs the async submit, modal closes (verified), filtered words chain into the custom-text flowconfig.time15 → 33, modal closes (verified), config restored afterwardsMerge Danger
Door: two-way — a dependency version bump; reverting restores 1.33.0 (upstream changes are additive/fix-level, no API removals).
Blast Radius: every form in the frontend (login/register, forgot password, profile, presets, quotes, custom text, settings modals). The upstream behaviour changes only alter edge-case validation (stale-error clearing,
deleteFieldprefix fix,isValidatingcounter) — the full suite plus the two browser-driven forms cover the main paths.